s390x: z17 target feature detection #1832
Conversation
folkertdev
force-pushed
the
s390x-z17-target-feature-detection
branch
from
d968db9 to
7bf8a59
Compare
| /// These values are part of the platform-specific [asm/elf.h][kernel], and are a selection of the | ||
| /// fields found in the [Facility Indications]. | ||
| /// | ||
| /// [Facility Indications]: https://www.ibm.com/support/pages/sites/default/files/2021-05/SA22-7871-10.pdf#page=63 |
There was a problem hiding this comment.
Where did you get the information about the facility bits that will be added in z17? (It is not included in the documentation at this link.)
There was a problem hiding this comment.
I can confirm that the z17 facility bit values are correct. The new version of the Principles of Operation including z17 features will be released shortly after the general availability of the new machine (which is next week).
folkertdev
force-pushed
the
s390x-z17-target-feature-detection
branch
from
7bf8a59 to
3809ead
Compare
| enable_if_set(133, Feature::guarded_storage); | ||
| enable_if_set(150, Feature::enhanced_sort); | ||
| enable_if_set(151, Feature::deflate_conversion); | ||
| // added in z17 |
There was a problem hiding this comment.
Do we need this comment? If so, should we add this information also for the vector-related facilities, and also specific machine information for pre-z17 machines?
There was a problem hiding this comment.
nah, this list doesn't really have structure to it, but it should be OK given the official docs.
| enable_if_set(151, Feature::deflate_conversion); | ||
| // added in z17 | ||
| enable_if_set(84, Feature::miscellaneous_extensions_4); | ||
| enable_if_set(86, Feature::message_security_assist_extension12); |
There was a problem hiding this comment.
We should really include all currently defined features here. What I see missing is the older variants of miscellaneous_extensions and messact_security_assist_extension. These all have defined facility bits.
There was a problem hiding this comment.
We can only add features here when they are also recognized by the compiler. I'll add them there, but that does not need to block this PR I think
There was a problem hiding this comment.
ah, I forgot that we did already add these to the compiler. Now they're in this PR too.
folkertdev
force-pushed
the
s390x-z17-target-feature-detection
branch
3 times, most recently
from
9ab93dc to
1ddb86f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
the build broke because a feature got stabilized: I'll add a commit to remove that line |
folkertdev
force-pushed
the
s390x-z17-target-feature-detection
branch
from
1ddb86f to
dac9666
Compare
tracking issue: rust-lang/rust#130869
I didn't add feature detection yet in #1826.
The implementation follows the information in rust-lang/rust#135413 (comment), in particular that
HWCAPis used to check for thevectorfeature because it needs kernel support, andstfleis used for the other features because they only need hardware support.cc @uweigand @taiki-e